Struts Apps - Checkstyle Results

##### Struts Apps

- Welcome

##### Components

- Struts Apps
- Struts EL
- Struts Extras
- Struts Faces
- Struts Scripting
- Struts Taglib
- Struts Tiles

##### Quick Links

- Apache Struts Home
- Struts 1

##### Project Documentation

- Project Information
- Project Reports
  - Checkstyle
  - CPD Report
  - JavaDocs
  - PMD Report
  - Source Xref
  - Surefire Report

## Checkstyle Results

The following document contains the results of Checkstyle.

## Summary

Files | Infos | Warnings | Errors
--- | --- | --- | ---
28 | 0 | 0 | 224

## Files

Files | I | W | E
--- | --- | --- | ---
org/apache/struts/webapp/example/AbstractBacking.java | 0 | 0 | 6
org/apache/struts/webapp/example/ApplicationMapping.java | 0 | 0 | 3
org/apache/struts/webapp/example/CheckLogonTag.java | 0 | 0 | 7
org/apache/struts/webapp/example/Constants.java | 0 | 0 | 3
org/apache/struts/webapp/example/EditRegistrationAction.java | 0 | 0 | 7
org/apache/struts/webapp/example/EditSubscriptionAction.java | 0 | 0 | 5
org/apache/struts/webapp/example/ExpiredPasswordException.java | 0 | 0 | 1
org/apache/struts/webapp/example/IndexBacking.java | 0 | 0 | 8
org/apache/struts/webapp/example/LinkSubscriptionTag.java | 0 | 0 | 6
org/apache/struts/webapp/example/LinkUserTag.java | 0 | 0 | 8
org/apache/struts/webapp/example/LogoffAction.java | 0 | 0 | 4
org/apache/struts/webapp/example/LogonAction.java | 0 | 0 | 9
org/apache/struts/webapp/example/LogonForm.java | 0 | 0 | 6
org/apache/struts/webapp/example/MainMenuBacking.java | 0 | 0 | 5
org/apache/struts/webapp/example/RegistrationBacking.java | 0 | 0 | 9
org/apache/struts/webapp/example/RegistrationForm.java | 0 | 0 | 12
org/apache/struts/webapp/example/SaveRegistrationAction.java | 0 | 0 | 10
org/apache/struts/webapp/example/SaveSubscriptionAction.java | 0 | 0 | 11
org/apache/struts/webapp/example/Subscription.java | 0 | 0 | 17
org/apache/struts/webapp/example/SubscriptionForm.java | 0 | 0 | 14
org/apache/struts/webapp/example/User.java | 0 | 0 | 24
org/apache/struts/webapp/example/UserDatabase.java | 0 | 0 | 2
org/apache/struts/webapp/example/memory/MemoryDatabasePlugIn.java | 0 | 0 | 10
org/apache/struts/webapp/example/memory/MemorySubscription.java | 0 | 0 | 12
org/apache/struts/webapp/example/memory/MemoryUser.java | 0 | 0 | 17
org/apache/struts/webapp/example/memory/MemoryUserDatabase.java | 0 | 0 | 6
org/apache/struts/webapp/example/memory/package.html | 0 | 0 | 1
org/apache/struts/webapp/example/package.html | 0 | 0 | 1

## Rules

Rules | Violations | Severity
--- | --- | ---
PackageHtml | 2 | Error
NewlineAtEndOfFile | 0 | Error
Translation | 0 | Error

JavadocMethod

- allowUndeclaredRTE: `"true"`

99

Error

JavadocType | 0 | Error
JavadocVariable | 6 | Error
JavadocStyle | 2 | Error
ConstantName | 4 | Error
LocalFinalVariableName | 0 | Error
LocalVariableName | 0 | Error
MemberName | 0 | Error
MethodName | 0 | Error
PackageName | 0 | Error
ParameterName | 0 | Error
StaticVariableName | 0 | Error
TypeName | 0 | Error

RegexpHeader

- header
  1: `/\*\s*`
  2: `\*\s*\$Id.*\$`
  3: `\*\s*`
  4: `\*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.`
  5: `\*\s*`
  6: `\*\s*Licensed under the Apache License, Version 2\.0 \(the .License.\);`
  7: `\*\s*you may not use this file except in compliance with the License\.`
  8: `\*\s*You may obtain a copy of the License at`
  9: `\*\s*`
  10: `\*\s*http://www\.apache\.org/licenses/LICENSE\-2\.0`
  11: `\*\s*`
  12: `\*\s*Unless required by applicable law or agreed to in writing, software`
  13: `\*\s*distributed under the License is distributed on an .AS IS. BASIS,`
  14: `\*\s*WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.`
  15: `\*\s*See the License for the specific language governing permissions and`
  16: `\*\s*limitations under the License\.`
  17: `\*/\s*`

26

Error

AvoidStarImport | 0 | Error
IllegalImport | 0 | Error
RedundantImport | 0 | Error
UnusedImports | 0 | Error
FileLength | 0 | Error

LineLength

- max: `"120"`
- ignorePattern: `"^ \* @version .*$"`

0

Error

MethodLength | 0 | Error
ParameterNumber | 0 | Error
EmptyForIteratorPad | 0 | Error

NoWhitespaceAfter

- tokens: `"BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"`

0

Error

NoWhitespaceBefore | 0 | Error
OperatorWrap | 23 | Error
ParenPad | 0 | Error
TypecastParenPad | 0 | Error
TabCharacter | 0 | Error
WhitespaceAfter | 0 | Error
WhitespaceAround | 2 | Error
ModifierOrder | 0 | Error
RedundantModifier | 24 | Error
AvoidNestedBlocks | 0 | Error
EmptyBlock | 0 | Error
LeftCurly | 0 | Error
NeedBraces | 27 | Error
RightCurly | 0 | Error
DoubleCheckedLocking | 0 | Error
EmptyStatement | 0 | Error
EqualsHashCode | 0 | Error
IllegalInstantiation | 0 | Error
InnerAssignment | 0 | Error
MagicNumber | 3 | Error
MissingSwitchDefault | 0 | Error
RedundantThrows | 0 | Error
SimplifyBooleanExpression | 0 | Error
SimplifyBooleanReturn | 0 | Error
FinalClass | 0 | Error
HideUtilityClassConstructor | 1 | Error
InterfaceIsType | 0 | Error

VisibilityModifier

- protectedAllowed: `"true"`

0

Error

ArrayTypeStyle | 2 | Error

GenericIllegalRegexp

- message: `"Line has trailing spaces."`
- format: `"\s+$"`

0

Error

TodoComment | 0 | Error
UpperEll | 0 | Error

## Details

### org/apache/struts/webapp/example/AbstractBacking.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 47
| Expected an @return tag. | 85
| Expected an @return tag. | 98
| Expected an @return tag. | 111
| Expected an @return tag. | 124

### org/apache/struts/webapp/example/ApplicationMapping.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 69
| Expected an @return tag. | 91

### org/apache/struts/webapp/example/CheckLogonTag.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 64
| Expected an @return tag. | 86
| Expected an @return tag. | 113
| Expected an @return tag. | 127
| 'if' construct must use '{}'s. | 132
| 'if' construct must use '{}'s. | 136

### org/apache/struts/webapp/example/Constants.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Utility classes should not have a public or default constructor. | 33
| Name 'Package' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 39

### org/apache/struts/webapp/example/EditRegistrationAction.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 80
| 'if' construct must use '{}'s. | 89
| '+' should be on a new line. | 92
| 'if' construct must use '{}'s. | 116
| 'else' construct must use '{}'s. | 118
| 'if' construct must use '{}'s. | 133

### org/apache/struts/webapp/example/EditSubscriptionAction.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 79
| '+' should be on a new line. | 93
| '+' should be on a new line. | 112
| 'if' construct must use '{}'s. | 145

### org/apache/struts/webapp/example/ExpiredPasswordException.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4

### org/apache/struts/webapp/example/IndexBacking.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Missing a Javadoc comment. | 43
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 43
| Expected an @return tag. | 52
| First sentence should end with a period. | 64
| Expected @param tag for 'actionEvent'. | 68
| '{' is not preceded with whitespace. | 68
| Expected an @return tag. | 75

### org/apache/struts/webapp/example/LinkSubscriptionTag.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Missing a Javadoc comment. | 51
| Missing a Javadoc comment. | 61
| Extra HTML tag found: </p> | 70
| Expected an @return tag. | 72
| Expected an @return tag. | 82

### org/apache/struts/webapp/example/LinkUserTag.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 78
| Expected an @return tag. | 100
| Expected an @return tag. | 127
| 'if' construct must use '{}'s. | 140
| 'if' construct must use '{}'s. | 143
| 'else' construct must use '{}'s. | 145
| Expected an @return tag. | 178

### org/apache/struts/webapp/example/LogoffAction.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 75
| '+' should be on a new line. | 88
| '+' should be on a new line. | 93

### org/apache/struts/webapp/example/LogonAction.java

Violation | Message | Line
--- | --- | ---
| Got an exception - java.lang.RuntimeException: Unable to get class information for @throws tag 'AppException'. | 0
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 79
| 'if' construct must use '{}'s. | 96
| 'if' construct must use '{}'s. | 101
| 'if' construct must use '{}'s. | 103
| '+' should be on a new line. | 118
| 'if' construct must use '{}'s. | 124
| 'else' construct must use '{}'s. | 126

### org/apache/struts/webapp/example/LogonForm.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 69
| Expected an @return tag. | 91
| Expected an @return tag. | 137
| 'if' construct must use '{}'s. | 141
| 'if' construct must use '{}'s. | 143

### org/apache/struts/webapp/example/MainMenuBacking.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Missing a Javadoc comment. | 41
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 41
| Expected an @return tag. | 50
| Expected an @return tag. | 67

### org/apache/struts/webapp/example/RegistrationBacking.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Missing a Javadoc comment. | 42
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 42
| Missing a Javadoc comment. | 48
| Expected an @return tag. | 54
| Expected an @return tag. | 80
| Expected an @return tag. | 101
| Expected an @return tag. | 126
| Expected an @return tag. | 152

### org/apache/struts/webapp/example/RegistrationForm.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 112
| Expected an @return tag. | 134
| Expected an @return tag. | 156
| Expected an @return tag. | 178
| Expected an @return tag. | 200
| Expected an @return tag. | 222
| Expected an @return tag. | 244
| Expected an @return tag. | 295
| '||' should be on a new line. | 302
| '||' should be on a new line. | 303
| '&&' should be on a new line. | 304

### org/apache/struts/webapp/example/SaveRegistrationAction.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 84
| '+' should be on a new line. | 100
| '+' should be on a new line. | 117
| '&&' should be on a new line. | 141
| '<' is not followed by whitespace. | 149
| '||' should be on a new line. | 174
| '+' should be on a new line. | 200
| 'if' construct must use '{}'s. | 207
| 'else' construct must use '{}'s. | 209

### org/apache/struts/webapp/example/SaveSubscriptionAction.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 82
| '+' should be on a new line. | 97
| '+' should be on a new line. | 114
| '+' should be on a new line. | 126
| '+' should be on a new line. | 134
| '+' should be on a new line. | 145
| '+' should be on a new line. | 146
| 'if' construct must use '{}'s. | 172
| 'if' construct must use '{}'s. | 192
| 'else' construct must use '{}'s. | 194

### org/apache/struts/webapp/example/Subscription.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 43
| Redundant 'public' modifier. | 43
| Redundant 'public' modifier. | 51
| Expected an @return tag. | 57
| Redundant 'public' modifier. | 57
| Expected an @return tag. | 63
| Redundant 'public' modifier. | 63
| Redundant 'public' modifier. | 71
| Expected an @return tag. | 77
| Redundant 'public' modifier. | 77
| Redundant 'public' modifier. | 85
| Expected an @return tag. | 91
| Redundant 'public' modifier. | 91
| Expected an @return tag. | 97
| Redundant 'public' modifier. | 97
| Redundant 'public' modifier. | 105

### org/apache/struts/webapp/example/SubscriptionForm.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 98
| Expected an @return tag. | 120
| Expected an @return tag. | 141
| Expected an @return tag. | 163
| Expected an @return tag. | 185
| Expected an @return tag. | 207
| Expected an @return tag. | 257
| 'if' construct must use '{}'s. | 262
| 'if' construct must use '{}'s. | 265
| 'if' construct must use '{}'s. | 268
| 'if' construct must use '{}'s. | 271
| 'if' construct must use '{}'s. | 274
| Expected an @return tag. | 286

### org/apache/struts/webapp/example/User.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 44
| Redundant 'public' modifier. | 44
| Expected an @return tag. | 50
| Redundant 'public' modifier. | 50
| Redundant 'public' modifier. | 58
| Expected an @return tag. | 64
| Redundant 'public' modifier. | 64
| Redundant 'public' modifier. | 72
| Expected an @return tag. | 78
| Redundant 'public' modifier. | 78
| Redundant 'public' modifier. | 86
| Expected an @return tag. | 92
| Redundant 'public' modifier. | 92
| Redundant 'public' modifier. | 100
| Expected an @return tag. | 107
| Redundant 'public' modifier. | 107
| Expected an @return tag. | 113
| Redundant 'public' modifier. | 113
| Expected an @return tag. | 128
| Redundant 'public' modifier. | 128
| Expected an @return tag. | 137
| Redundant 'public' modifier. | 137
| Redundant 'public' modifier. | 149

### org/apache/struts/webapp/example/UserDatabase.java

Violation | Message | Line
--- | --- | ---
| Got an exception - java.lang.RuntimeException: Unable to get class information for @throws tag 'IllegalArgumentExceptionif'. | 0
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4

### org/apache/struts/webapp/example/memory/MemoryDatabasePlugIn.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Missing a Javadoc comment. | 92
| Missing a Javadoc comment. | 96
| '+' should be on a new line. | 139
| '+' should be on a new line. | 156
| Expected an @return tag. | 205
| '1024' is a magic number. | 225
| '1024' is a magic number. | 228
| Array brackets at illegal position. | 229
| '1024' is a magic number. | 229

### org/apache/struts/webapp/example/memory/MemorySubscription.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Missing a Javadoc comment. | 84
| Missing a Javadoc comment. | 88
| Expected an @return tag. | 96
| Missing a Javadoc comment. | 106
| Missing a Javadoc comment. | 110
| Missing a Javadoc comment. | 120
| Missing a Javadoc comment. | 124
| Expected an @return tag. | 132
| Missing a Javadoc comment. | 142
| Missing a Javadoc comment. | 146
| Expected an @return tag. | 157

### org/apache/struts/webapp/example/memory/MemoryUser.java

Violation | Message | Line
--- | --- | ---
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Expected an @return tag. | 90
| Missing a Javadoc comment. | 100
| Missing a Javadoc comment. | 104
| Missing a Javadoc comment. | 114
| Missing a Javadoc comment. | 118
| Missing a Javadoc comment. | 128
| Missing a Javadoc comment. | 132
| Missing a Javadoc comment. | 142
| Missing a Javadoc comment. | 146
| Expected an @return tag. | 155
| Array brackets at illegal position. | 158
| Expected an @return tag. | 168
| Expected an @return tag. | 185
| '+' should be on a new line. | 190
| Expected an @return tag. | 210
| Expected an @return tag. | 244

### org/apache/struts/webapp/example/memory/MemoryUserDatabase.java

Violation | Message | Line
--- | --- | ---
| Got an exception - java.lang.RuntimeException: Unable to get class information for @throws tag 'IllegalArgumentExceptionif'. | 0
| Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4
| Missing a Javadoc comment. | 83
| Missing a Javadoc comment. | 85
| Missing a Javadoc comment. | 87
| Missing a Javadoc comment. | 91

### org/apache/struts/webapp/example/memory/package.html

Violation | Message | Line
--- | --- | ---
| Missing package documentation file. | 0

### org/apache/struts/webapp/example/package.html

Violation | Message | Line
--- | --- | ---
| Missing package documentation file. | 0